On Mon, Sep 09, 2013 at 02:48:55PM +0300, Michael S. Tsirkin wrote: > On Mon, Sep 09, 2013 at 12:45:12PM +0100, Peter Maydell wrote: > > On 9 September 2013 12:41, Michael S. Tsirkin <m...@redhat.com> wrote: > > > On Mon, Sep 09, 2013 at 02:21:35PM +0300, Marcel Apfelbaum wrote: > > >> Priority is used to make visible some subregions by obscuring > > >> the parent MemoryRegion addresses overlapping with the subregion. > > >> > > >> By allowing the priority to be negative the opposite can be done: > > >> Allow a subregion to be visible on all the addresses not covered > > >> by the parent MemoryRegion or other subregions. > > >> > > >> Signed-off-by: Marcel Apfelbaum <marce...@redhat.com> > > > > > > Seems harmless enough. > > > > > > Reviewed-by: Michael S. Tsirkin <m...@redhat.com> > > > > No, the idea is good but this version is just broken. > > See the comments I made on the previous version which > > Marcel ignored :-( > > > > -- PMM > > You are right, I missed the bugs. > Good catch, thanks. >
So I guess it's only an Acked-by: Michael S. Tsirkin <m...@redhat.com> at this point :)
