Am 01.09.2013 20:28, schrieb Antony Pavlov: > On Sat, 31 Aug 2013 21:09:20 +0200 > Andreas Färber <afaer...@suse.de> wrote: > >> Am 31.08.2013 19:22, schrieb Antony Pavlov: >>> Use of SysBusDevice::init is deprecated. >>> Use Device::realize instead of SysBusDevice::init. >>> Check dma/pl330.c for an example of the pattern. >>> >>> Also introduce TypeInfo::instance_init milkymist_uart_init() >>> as char/pl011.c does. >>> >>> Reported-by: Peter Crosthwaite <peter.crosthwa...@xilinx.com> >>> Signed-off-by: Antony Pavlov <antonynpav...@gmail.com> >>> CC: Peter Crosthwaite <peter.crosthwa...@xilinx.com> >>> CC: Michael Walle <mich...@walle.cc> >>> CC: Andreas Färber <afaer...@suse.de> >>> --- >>> hw/char/milkymist-uart.c | 24 ++++++++++++++---------- >>> 1 file changed, 14 insertions(+), 10 deletions(-) >> >> Thanks, applied to qom-next (with shortened commit message): >> https://github.com/afaerber/qemu-cpu/commits/qom-next >> > > That's about the patch number 1 ( milkymist-uart: use qemu_chr_fe_write_all() > instead of qemu_chr_fe_write()) ?
No, it's about patch 2, which I replied to. Patch 1 is not a QOM conversion but an unrelated bug fix - it can be handled either by the lm32 maintainer or by whomever takes care of the char layer these days (Anthony/Gerd). Regards, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
