Am 28.08.2013 18:11, schrieb Peter Maydell: > On 28 August 2013 16:35, Andreas Färber <afaer...@suse.de> wrote: >> For the MPCore series in my ARM/Tegra tree you wanted an assert for >> object_initialize(). I am waiting for you to comment on my more >> invasive/complete series (last part being optional), which would then >> with any suggested changes go through my QOM tree before I add more uses >> of object_initialize() that would need to be converted. > > Ah, OK. I'm moving house this week so probably won't get to > detailed review til next week, but I think in general it looked OK. > Having to pass "&X, sizeof(X)" in the most common case is > a little unfortunate but I think the bus related code and so on > convinced me it was necessary.
Yeah, it turned into more work than I expected ;) but there were at least two cases (still need to reply) where the macro-fied version would've checked the wrong thing and my patches are intentionally deviating from the usual pattern - main_system_bus and a sec_bus. Thanks, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
