On 23 August 2013 19:11, Richard Henderson <r...@twiddle.net> wrote: > On 08/23/2013 09:12 AM, Peter Maydell wrote: >> #define CPSR_V (1 << 28) >> #define CPSR_C (1 << 29) >> #define CPSR_Z (1 << 30) >> -#define CPSR_N (1 << 31) >> +#define CPSR_N (1U << 31) >> #define CPSR_NZCV (CPSR_N | CPSR_Z | CPSR_C | CPSR_V) > > You'd be better off making all of the CPSR bits unsigned, I think.
Agreed; let's be consistent. -- PMM
