Ping? There are reviews already? Anybody to apply it?
Michal
On 08/12/2013 06:34 PM, Michal Novotny wrote:
> Output error message using qemu's error_report() function when user
> provides the invalid machine type on the command line. This also saves
> time to find what issue is when you downgrade from one version of qemu
> to another that doesn't support required machine type yet (the version
> user downgraded to have to have this patch applied too, of course).
>
> Signed-off-by: Michal Novotny <minov...@redhat.com>
> ---
> vl.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/vl.c b/vl.c
> index f422a1c..9b4a3f9 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2671,6 +2671,11 @@ static QEMUMachine *machine_parse(const char *name)
> if (machine) {
> return machine;
> }
> +
> + if (name && !is_help_option(name)) {
> + error_report("Unsupported machine type");
> + }
> +
> printf("Supported machines are:\n");
> for (m = first_machine; m != NULL; m = m->next) {
> if (m->alias) {
--
Michal Novotny <minov...@redhat.com>, RHCE, Red Hat
Virtualization | libvirt-php bindings | php-virt-control.org
