Il 22/08/2013 13:45, Stefan Hajnoczi ha scritto: > On Mon, Aug 12, 2013 at 12:41:50PM +0100, Alex Bligh wrote: >> > From: Alexandre Derumier <aderum...@odiso.com> >> > >> > Add a -C option to skip volume creation on qemu-img convert. >> > This is useful for targets such as rbd / ceph, where the >> > target volume may already exist; we cannot always rely on >> > qemu-img convert to create the image, as dependent on the >> > output format, there may be parameters which are not possible >> > to specify through the qemu-img convert command line. >> > >> > Signed-off-by: Alexandre Derumier <aderum...@odiso.com> >> > Signed-off-by: Alex Bligh <a...@alex.org.uk> >> > --- >> > qemu-img-cmds.hx | 4 ++-- >> > qemu-img.c | 39 ++++++++++++++++++++++++--------------- >> > qemu-img.texi | 15 ++++++++++++++- >> > 3 files changed, 40 insertions(+), 18 deletions(-) > Looks good but please include a new qemu-iotest test case that checks: > > 1. Error if the target volume does not exist. > > 2. Success if a correctly sized target volume exists. > > 3. ?? if an incorrectly sized target volume exists. > > ...and anything else you feel is worth testing. > > I recommend keeping the test volume size small so the test case can > execute quickly. 1 MB should be fine for raw or qcow2 images.
Also, this is the same as some HMP commands' "-n" option (live snapshots, mirroring, backup) so I suggest to use that name. Paolo
