Am 01.08.2013 um 05:23 hat Jeff Cody geschrieben:
> This moves the endian translation functions out from the vhdx.c source,
> into a separate source file. In addition to the previously defined
> endian functions, new endian translation functions for log support are
> added as well.
>
> Signed-off-by: Jeff Cody <jc...@redhat.com>
> +void vhdx_log_entry_hdr_le_import(VHDXLogEntryHeader *hdr)
> +{
> + assert(hdr != NULL);
> +
> + le32_to_cpus(&hdr->signature);
> + le32_to_cpus(&hdr->checksum);
> + le32_to_cpus(&hdr->entry_length);
> + le32_to_cpus(&hdr->tail);
> + le64_to_cpus(&hdr->sequence_number);
> + le32_to_cpus(&hdr->descriptor_count);
> + leguid_to_cpus(&hdr->log_guid);
> + le64_to_cpus(&hdr->flushed_file_offset);
> + le64_to_cpus(&hdr->last_file_offset);
> +}
> +
> +void vhdx_log_entry_hdr_le_export(VHDXLogEntryHeader *hdr)
> +{
> + assert(hdr != NULL);
> +
> + cpu_to_le32s(&hdr->signature);
> + cpu_to_le32s(&hdr->checksum);
> + cpu_to_le32s(&hdr->entry_length);
> + cpu_to_le32s(&hdr->tail);
> + cpu_to_le64s(&hdr->sequence_number);
> + cpu_to_le32s(&hdr->descriptor_count);
> + cpu_to_le64s(&hdr->flushed_file_offset);
> + cpu_to_le64s(&hdr->last_file_offset);
> + cpu_to_leguids(&hdr->log_guid);
> +}
Almost as critical as Stefan's comment: Can you keep the order of fields
consistent between import and export?
Kevin
