On Mon, Aug 05, 2013 at 08:44:07PM +0200, Charlie Shepherd wrote: > This patch updates the callers of block layer functions converted to explicit > coroutine_fn annotation in the previous patch.
It looks like this patch is made of three parts: - updating the annotations, following the rule "caller of coroutine_fn must be coroutine_fn", - introducing a run_handler function in qemu-img.c, - replacing bdrv_* by bdrv_*_sync in qemu-io-cmds.c. The first one is purely mechanical and boring. The second one is moderately inventive (note that I did not review the code in detail). The third one is simple but definitely deserves some explanation. Again, I think this could be split in three different patches, with an expanded commit message. Best, -- Gabriel