On Wed, 18 Nov 2009 16:17:02 +0100
Markus Armbruster <arm...@redhat.com> wrote:
> Luiz Capitulino <lcapitul...@redhat.com> writes:
>
> > Signed-off-by: Luiz Capitulino <lcapitul...@redhat.com>
> > ---
> > hw/qdev.c | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/hw/qdev.c b/hw/qdev.c
> > index d19d531..875ca50 100644
> > --- a/hw/qdev.c
> > +++ b/hw/qdev.c
> > @@ -29,6 +29,7 @@
> > #include "qdev.h"
> > #include "sysemu.h"
> > #include "monitor.h"
> > +#include "qerror.h"
> >
> > static int qdev_hotplug = 0;
> >
> > @@ -176,8 +177,7 @@ DeviceState *qdev_device_add(QemuOpts *opts)
> > /* find driver */
> > info = qdev_find_info(NULL, driver);
> > if (!info) {
> > - qemu_error("Device \"%s\" not found. Try -device '?' for a
> > list.\n",
> > - driver);
> > + qemu_error_new(QERR_DEVICE_NOT_FOUND, driver);
> > return NULL;
> > }
> > if (info->no_user) {
>
> Not obvious from this patch, but we lose the "Try -device '?' for a
> list" hint here.
Yes, this happens because this is a generic error and '-device' is
qdev command-line specific.
