Markus, Luiz > > A conversion from fprintf() to error_report() is always an improvement, > > because > > No disagreement here.
Thank you for discussing this. I will update my patch by converting from fprintf(stderr, ..) to error_report(). Seiji > -----Original Message----- > From: Luiz Capitulino [mailto:lcapitul...@redhat.com] > Sent: Monday, July 29, 2013 8:35 PM > To: Markus Armbruster > Cc: Andreas Färber; Seiji Aguchi; ler...@redhat.com; qemu-devel@nongnu.org; > Tomoki Sekiyama > Subject: Re: [Qemu-devel] [PATCH] Convert stderr message calling > error_get_pretty() to error_report() to prepend timestamp > > On Tue, 30 Jul 2013 02:00:40 +0200 > Markus Armbruster <arm...@redhat.com> wrote: > > > Luiz Capitulino <lcapitul...@redhat.com> writes: > > > > > On Mon, 29 Jul 2013 23:23:32 +0200 > > > Andreas Färber <afaer...@suse.de> wrote: > > > > > >> Am 29.07.2013 23:20, schrieb Luiz Capitulino: > > >> > On Mon, 22 Jul 2013 23:23:29 +0200 > > >> > Andreas Färber <afaer...@suse.de> wrote: > > >> >> Am 22.07.2013 23:03, schrieb Seiji Aguchi: > > >> >>> Convert stderr messages calling error_get_pretty() > > >> >>> to error_report(). > > >> >> > > >> >> How is this related to error_get_pretty()? > > >> > > > >> > Yeah, we're converting fprintf(stderr,) calls to error_report() so that > > >> > error messages get a timestamp. > > >> > > >> Want to add that to my http://wiki.qemu.org/DeveloperNews so that people > > >> reading it stop adding new ones? :) > > > > > > Big IMHO here, but honestly speaking I'm not a huge fan of error_report() > > > because I think that random code shouldn't be allowed to print to the > > > monitor (only HMP code should). > > > > A conversion from fprintf() to error_report() is always an improvement, > > because > > No disagreement here.
