Am 29.07.2013 um 16:03 hat Paolo Bonzini geschrieben: > Il 29/07/2013 15:43, Kevin Wolf ha scritto: > > Am 25.07.2013 um 16:23 hat Paolo Bonzini geschrieben: > >> Some bdrv_is_allocated callers do not expect errors, but the fallback > >> in qcow2.c might make other callers trip on assertion failures or > >> infinite loops. > >> > >> Fix the callers to always look for errors. > >> > >> Cc: qemu-sta...@nongnu.org > >> Reviewed-by: Eric Blake <ebl...@redhat.com> > >> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> > > > > Good idea, but there seem to be a few more callers that don't handle > > errors yet. Not sure what your criterion for fixing callers or not was. > > Did you simply miss the rest? > > In general, I didn't bother about callers that didn't handle *pnum = 0 > correctly (for example block-migration.c and commit). But I see now > that the ones in qemu-io-cmds.c are due to a bad rebase.
Would you mind fixing the already broken ones as well? > (BTW, I just noticed now that both block-migration.c and commit also run > outside a coroutine, and thus rely on bdrv_is_allocated creating one). Ah well, I missed those, too bad. I won't insist on removing the synchronous path then. Kevin
