On Sun, Jul 28, 2013 at 04:59:18PM +0200, Andreas Färber wrote: > Am 28.07.2013 16:08, schrieb Michael S. Tsirkin: > > On Sun, Jul 28, 2013 at 03:41:07AM +0200, Andreas Färber wrote: > >> Hello Michael and Gerd, > >> > >> As discussed, this series attempts to clean up PCIe devices fiddling with > >> individual PCIe VMState fields. It is based on my qom-next queue, > >> containing > >> type and field changes for PCIe devices. > >> > >> Patch 1 assumes the following are equivalent: > >> a) - Struct A > >> - Field Aa > >> ... > >> - Field X > >> ... > >> b) - Struct A > >> - Field Aa > >> ... > >> - Field X > >> > >> Patch 2 relies on XHCI not being released yet, thus no compatibiliy > >> concerns. > >> > >> Patch 3 assumes the following are equivalent: > >> a) - Struct A > >> - Field Aa > >> ... > >> - Field X > >> b) - Struct A > >> - Field Aa > >> ... > >> - Subsection Ax > >> - Field X > >> > >> CC'ing Juan to verify which of these are correct/safe. > > > > As far as I know 2a and 2b are not equivalent: subsections > > are serialized in the file. > > I'm guessing you mean scenarios 3a and 3b. Too bad. > > But when we want to unify PCI and PCIe as you suggested elsewhere, > introducing a PCIe-only subsection in patch 2 seems a bad idea. > > In that case we could use VMSTATE_STRUCT_TEST(), I'll look into that.
Right. > Using that I think we can postpone this beyond 1.6, since XHCI is not > initializing AER. > > Series formally retracted. > > > You really should test by migrating to file (e.g. before > > starting the guest) and checking. > > Also, migrate to file from before patch and load after patch. > > OK. For virtio and NICs that's trivial and for the ioh there's > docs/q35-chipset.cfg. > > How do I use and test those xio upstream/downstream PCIe devices? > > Andreas > > -- > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
