On Fri, Jul 26, 2013 at 11:32:29PM +0200, Andreas Färber wrote: > Am 23.07.2013 12:32, schrieb Max Filippov: > > On Wed, Jul 10, 2013 at 2:23 AM, Andreas Färber <afaer...@suse.de> wrote: > >> Hello, > >> > >> This series cleans up gdbstub by changing all its internal CPU state to > >> CPUState > >> and by moving most target-specific code into the target directories. > >> > >> Support for m68k, moxie and unicore32 to set the PC via gdbstub is added. > >> > >> Lightweight subclasses for XtensaCPU are introduced, keeping the > >> XtensaConfig > >> mechanisms, to stop xtensa from deviating at gdbstub level wrt register > >> count. > >> > >> I still wonder whether there would be interest in adding a > >> "program-counter" > >> dynamic property to the CPU, given that a setter has been factored out > >> here? > >> > >> v3 avoids find_cpu() related breakages by deferring GDBState::c_cpu > >> conversion > >> until GDBState::g_cpu and find_cpu() can easily be converted, too. > >> > >> Available for testing at: > >> git://github.com/afaerber/qemu-cpu.git qom-cpu-11.v3 > >> https://github.com/afaerber/qemu-cpu/commits/qom-cpu-11.v3 > > > > xtensa parts: Acked-by: Max Filippov <jcmvb...@gmail.com> > > Thanks, applied to qom-cpu: > https://github.com/afaerber/qemu-cpu/commits/qom-cpu > > Edgar, since I got no feedback on the crisv10 patch but got an ack on > the equivalent do_interrupt() change, I'm assuming you're okay with > this. We can still do code cleanups unifying pre-v32 stuff as follow-up.
Yes, these are good changes, thanks! Cheers, Edgar
