On Thu, Jul 25, 2013 at 05:50:55PM +0200, Andreas Färber wrote: > Am 24.07.2013 18:01, schrieb Michael S. Tsirkin: > > This code can also be found here: > > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git acpi > > > > Please review, and consider for 1.6. > > Quite frankly, this is still not looking the way I imagined it based on > the KVM call discussion and Anthony's comments that I remember:
By the way, for examples which are exactly like this code here, look no further than: FWCfgState *fw_cfg_find(void); and the use in hw/misc/pvpanic.c of said API. Here we have device implementing an API to find it, and through this pointer, it is accessed by more APIs access its state. This is exactly what my patches do for piix etc. So if you don't like this approach, please change existing code using it. -- MST