On 07/17/2013 03:42 AM, Fam Zheng wrote: > Similar to drive-backup, but this command uses a device id as target > instead of creating/opening an image file. > > Signed-off-by: Fam Zheng <f...@redhat.com> > --- > blockdev.c | 71 > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > qapi-schema.json | 49 ++++++++++++++++++++++++++++++++++++++ > qmp-commands.hx | 22 ++++++++++++++++++ > 3 files changed, 142 insertions(+) >
> +++ b/qapi-schema.json
> @@ -1665,6 +1665,40 @@
> '*on-target-error': 'BlockdevOnError' } }
>
> ##
> +# @BlockdevBackup
> +#
> +{ 'type': 'BlockdevBackup',
> + 'data': { 'device': 'str', 'target': 'str',
> + 'sync': 'MirrorSyncMode',
> + '*speed': 'int',
> + '*on-source-error': 'BlockdevOnError',
> + '*on-target-error': 'BlockdevOnError' } }
Seems okay. But what is missing is the addition of this type into the
union used for 'transaction' - shouldn't it be possible to mix this with
other transaction capabilities?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
