Hi Andreas, On Tue, Jul 16, 2013 at 10:19 PM, Andreas Färber <afaer...@suse.de> wrote: > Am 16.07.2013 04:00, schrieb Jia Liu: >> We should free typename here. >> >> Signed-off-by: Jia Liu <pro...@gmail.com> >> --- >> target-openrisc/cpu.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/target-openrisc/cpu.c b/target-openrisc/cpu.c >> index 6d40f1b..e348df0 100644 >> --- a/target-openrisc/cpu.c >> +++ b/target-openrisc/cpu.c >> @@ -99,6 +99,7 @@ static ObjectClass *openrisc_cpu_class_by_name(const char >> *cpu_model) >> >> typename = g_strdup_printf("%s-" TYPE_OPENRISC_CPU, cpu_model); >> oc = object_class_by_name(typename); >> + g_free(typename); >> if (oc != NULL && (!object_class_dynamic_cast(oc, TYPE_OPENRISC_CPU) || >> object_class_is_abstract(oc))) { >> return NULL; > > Reviewed-by: Andreas Färber <afaer...@suse.de>
Thank you, Andreas. May you want to review the other three? :) I've tested them all. > > Andreas > > -- > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg Regards, Jia.