On Thu, Jul 11, 2013 at 12:52:56PM -0600, Eric Blake wrote:
> On 07/11/2013 08:28 AM, Amos Kong wrote:
> > Markus added some comments on old patchset, this patch contains
> > some additional fixes, it's based on MST's PCI tree.
> >
> > * Fix typos (missed 1.6, NIC)
> > * Don't initialize list point at its declaration
> > * Always notify QMP client if mactable is changed
> > * Returns NULL list if no net client supports rx-filter querying.
> >
> > BTW, we can also use e1000 with macvtap device, so we can implement
> > a query_rx_filter function for e1000 in future.
> >
> > Signed-off-by: Amos Kong <ak...@redhat.com>
> > ---
> > hw/net/virtio-net.c | 24 ++++++++++++++----------
> > net/net.c | 19 ++++++++++---------
> > qapi-schema.json | 11 ++++++-----
> > qmp-commands.hx | 10 +++++-----
> > 4 files changed, 35 insertions(+), 29 deletions(-)
>
> Reviewed-by: Eric Blake <ebl...@redhat.com>
>
> > @@ -3724,13 +3724,14 @@
> > #
> > # @all: receive all assigned packets
> > #
> > +# Since: 1.6
> > ##
> > { 'enum': 'RxState', 'data': [ 'normal', 'none', 'all' ] }
>
> I don't see RxState in the latest qemu.git (c170a23c); is it worth
> trying to squash this in place to the pull request of the earlier
> series, instead of as a followup patch?
>
> --
> Eric Blake eblake redhat com +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>
It's easy for me to squash when I apply.
Marcus - you were the second persons with comments here, are you happy
with follow-up patches or do you prefer a full repost?
--
MST
