On 07/09/2013 02:41 PM, Eric Blake wrote: > On 07/04/2013 06:52 AM, Stefan Hajnoczi wrote: >> On Tue, Jun 18, 2013 at 05:31:52PM +0800, Dong Xu Wang wrote: >>> These patches will replace QEMUOptionParameter with QemuOpts. Change logs >>> please go to each patch's commit message. >>> >>> Dong Xu Wang (7): >>> add def_value_str in QemuOptDesc struct and rewrite qemu_opts_print >>> avoid duplication of default value in QemuOpts >>> Create four QemuOptsList related functions >>> Create some QemuOpts functons >>> Use QemuOpts support in block layer >>> query-command-line-options outputs def_value_str >>> remove QEMUOptionParameter related functions and struct >>> > >>> V15->V16: >>> 1) discard double-initialization. >>> 2) use pointer directly, not g_strdup. >>> 3) modify query-command-line-options related code. >>> V14->V15: >>> 1) Only delete enum QEMUOptionParType. >> >> eblake: You commented on the last revision. Are you happy with v16? > > Apologies for my delays (still digging myself out of 3 weeks > accumulation of mail after my vacation); I'll review within 24 hours.
At this point, I think a v17 is warranted (comments on individual patches). -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
