Hi Andreas, On Wed, Jul 10, 2013 at 6:25 PM, Andreas Färber <afaer...@suse.de> wrote: > Am 10.07.2013 09:41, schrieb Peter Maydell: >> On 10 July 2013 06:08, <peter.crosthwa...@xilinx.com> wrote: >>> From: Peter Crosthwaite <peter.crosthwa...@xilinx.com> >>> >>> The ARM A9 MPCore has a timer that is global to all CPUs in the mpcore. >>> The timer is shared but each CPU has a private independent comparator >>> and interrupt. >>> >>> Original version contributed by Francois LEGAL. >>> >>> Signed-off-by: Peter Crosthwaite <peter.crosthwa...@xilinx.com> >>> --- >>> Francois, do you want to re-add your SOB? I have changed the device >>> a lot since your V2. > > If you have a DCO for a patch you're reusing, you should never "drop" it > from your patch. You can still leave the textual explanation there. > >> The usual way to indicate this (assuming Francois signed off the >> original patchset) is something like: >> >> Signed-off-by: Original Author >> [You: <short description of subsequent changes>] >> Signed-off-by: Your Name > > Add to that, the difference between From and SOB indicates that you did > more than just cosmetic touches. For example, when I wrote from scratch > a new SoC QOM object I used my From and the original author's Sob (to > put the blame on me while recording the DCO), whereas when I purely > updated code to MemoryRegions, Coding Style, QOM casts, etc. I use the > original author's From and [AF: ...].
This is much more than a stylistic change, its very heavily refactored. I think its better to --reset-author but ill bring the SOB accross. Whereas with P2 all I have done is split of the MPCore changes from original file verbatim, so I guess that should be original author. Regards, Peter > > Andreas > > -- > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg >
