Hi Andreas,
On Tue, Jul 2, 2013 at 6:18 PM, Andreas Färber <afaer...@suse.de> wrote: > > Hi Jia, > > Am 02.07.2013 11:29, schrieb Jia Liu: > > On Tue, Jul 2, 2013 at 5:11 PM, Dongxue Zhang <elta....@gmail.com > > <mailto:elta....@gmail.com>> wrote: > >> > >> Make target-openrisc running OK by add typename in > > openrisc_cpu_class_by_name(). > >> > >> Signed-off-by: Dongxue Zhang <elta....@gmail.com > > <mailto:elta....@gmail.com>> > >> --- > >> target-openrisc/cpu.c | 4 +++- > >> 1 file changed, 3 insertions(+), 1 deletion(-) > >> > >> diff --git a/target-openrisc/cpu.c b/target-openrisc/cpu.c > >> index fd90d37..d38c28b 100644 > >> --- a/target-openrisc/cpu.c > >> +++ b/target-openrisc/cpu.c > >> @@ -96,12 +96,14 @@ static void openrisc_cpu_initfn(Object *obj) > >> static ObjectClass *openrisc_cpu_class_by_name(const char *cpu_model) > >> { > >> ObjectClass *oc; > >> + char *typename; > >> > >> if (cpu_model == NULL) { > >> return NULL; > >> } > >> > >> - oc = object_class_by_name(cpu_model); > >> + typename = g_strdup_printf("%s-" TYPE_OPENRISC_CPU, cpu_model); > >> + oc = object_class_by_name(typename); > >> if (oc != NULL && (!object_class_dynamic_cast(oc, > > TYPE_OPENRISC_CPU) || > >> object_class_is_abstract(oc))) { > >> return NULL; > > > > Thanks for your fix, it looks and test good to me. > > Sorry for the breakage. Do you want to add a > Reviewed-by/Tested-by/Acked-by? I'd queue it for you then. > > If you could upload a Linux test image somewhere that may help avoid > breakages in the future. I've upload a Linux test image to my Google Drive. https://docs.google.com/file/d/0BxeTrz3x0CBLbTNmU0lrV1Y0V0U/edit > > Also we reported that there was no maintainer for target-openrisc/ in > MAINTAINERS file, do you want to put yourself there so that you are > CC'ed on patches? > > Here's a pointer to the latest refactoring that partially affects or32: > http://lists.gnu.org/archive/html/qemu-devel/2013-06/msg05354.html > > Regards, > Andreas > > -- > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg Regards, Jia
