Peter Maydell <peter.mayd...@linaro.org> writes:
> On 4 July 2013 14:09, Markus Armbruster <arm...@redhat.com> wrote:
>>
>> +/**
>> + * Get machine options
>> + *
>> + * Returns: machine options (never null).
>> + */
>> +QemuOpts *qemu_get_machine_opts(void)
>> +{
>> + QemuOptsList *list;
>> + QemuOpts *opts;
>> +
>> + list = qemu_find_opts("machine");
>> + assert(list);
>> + opts = qemu_opts_find(list, NULL);
>> + if (!opts) {
>> + opts = qemu_opts_create_nofail(list);
>> + }
>> + return opts;
>> +}
>
> This looks a bit odd -- why are we creating new
> options in a function that claims to only be querying
> them?
So we never return null. If it bothers you, I can initialize the
options to empty somewhere else, and assert they exist here.
