On Thu, 27 Jun 2013 16:22:06 +0200 Markus Armbruster <arm...@redhat.com> wrote:
> The first patch is a straightforward bug fix. > > The rest fix code to match documentation. The patches take pains to > preserve command-line, HMP and QMP bug-compatibility. I'm not sure > that's actually needed, because: > > * All: the documented way to use the driver never worked in any > released version, and the way that worked was undocumented. > > * QMP: I doubt anyone used chardev-add / chardev-remove in anger, > because serious use surely would've run into the "qemu-char: Fix ID > reuse after chardev-remove for qapi-based init" bug. > > I include the compatibility gunk anyway, so we can have a more > informed discussion. Series looks good to me, but patch 3/4 doesn't apply anymore. I've applied patch 1/4 anyway.
