Am 24.06.2013 09:01, schrieb peter.crosthwa...@xilinx.com:
> diff --git a/hw/pci/shpc.c b/hw/pci/shpc.c
> index d35c2ee..aa45e77 100644
> --- a/hw/pci/shpc.c
> +++ b/hw/pci/shpc.c
> @@ -252,9 +252,9 @@ static void shpc_free_devices_in_slot(SHPCDevice *shpc,
> int slot)
> for (devfn = PCI_DEVFN(pci_slot, 0);
> devfn <= PCI_DEVFN(pci_slot, PCI_FUNC_MAX - 1);
> ++devfn) {
> - PCIDevice *affected_dev = shpc->sec_bus->devices[devfn];
> + DeviceState *affected_dev = DEVICE(shpc->sec_bus->devices[devfn]);
> if (affected_dev) {
Did you verify this works as expected? Or might we need
object_dynamic_cast() here? I remember we had issues with assertions in
the past, not sure if all are resolved...
Andreas
> - qdev_free(&affected_dev->qdev);
> + qdev_free(affected_dev);
> }
> }
> }
[snip]
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
