On Sat, Jun 29, 2013 at 03:47:26PM +0200, Stefan Weil wrote: > i686-w64-mingw32-gcc (GCC) 4.6.3 from Debian wheezy reports these warnings: > > hw/ppc/spapr_hcall.c:188:1: warning: > control reaches end of non-void function [-Wreturn-type] > > hw/ppc/spapr_pci.c:454:1: warning: > control reaches end of non-void function [-Wreturn-type] > > Both warnings are fixed by using g_assert_not_reached instead of assert. > A second line with assert(0) in spapr_pci.c which did not raise a compiler > warning was modified, too, because g_assert_not_reached documents the > purpose of that statement and is not removed in release builds. > > Signed-off-by: Stefan Weil <s...@weilnetz.de>
Makes sense to me.
Acked-by: David Gibson <da...@gibson.dropbear.id.au>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
pgpGMjAH0darj.pgp
Description: PGP signature
