On Jun 24, 2013, at 12:41 PM, Peter Maydell wrote: > On 24 June 2013 03:03, Stacey Son <s...@freebsd.org> wrote: >> This change add more strace formating for popular system calls. It also >> separates out *BSD and architecture dependent code. In addition, it >> changes TARGET_OS in configure (and in the associated makefiles) to >> what it should really be: HOST_OS. > > You introduced TARGET_OS in the first place. Please don't put > code in in one patch and then change it in a later one; rearrange > your patchset to avoid this. > > This patch is also doing too many things at once. > >> +if [ "$HOST_ABI_DIR" != "" ]; then >> + echo "HOST_ABI_DIR=$HOST_ABI_DIR" >> $config_target_mak >> +fi > > Host specific definitions in the target config? Doesn't look right.
You're right. I originally used TARGET_OS but later decided that it was not the target but really the host os that was being defined. Then after rebasing I noticed that there was a change defining TARGET_ABI_DIR so I changed HOST_OS to HOST_ABI_DIR to be consistent with that change. I really need to may this change back when TARGET_OS is first introduced. -stacey.
