On 06/22/2013 03:58 AM, Peter Maydell wrote: > On 22 June 2013 03:10, Richard Henderson <r...@twiddle.net> wrote: >> + ldflags="$ldflags $textseg_ldflags" >> fi >> >> echo "LDFLAGS+=$ldflags" >> $config_target_mak > > Should we really be putting this in LDFLAGS? That seems > likely to end up getting accidentally applied in places > where we don't want it (helper binaries, etc). It seems > like it would be more robust to have it in a special > variable which we only ever explicitly apply to linking > the foo-linux-user binary.
This is within the target subdir, not in the main top level. So... What helper binaries? Modifying ldflags is what we do now. If you think that we should change to a different variable, then I think that should be a separate change. r~
