Andreas Färber <afaer...@suse.de> writes:
> Am 19.06.2013 22:40, schrieb Anthony Liguori:
>> RTAS is a hypervisor provided binary blob that a guest loads and
>> calls into to execute certain functions. It's similar to the
>> vsyscall page in Linux or the short lived VMCI paravirt interface
>> from VMware.
>>
>> The QEMU implementation of the RTAS blob is simply a passthrough
>> that proxies all RTAS calls to the hypervisor via an hypercall.
>>
>> While we pass a CPU argument for hypercall handling in QEMU, we
>> don't pass it for RTAS calls. Since some RTAs calls require
>
> "RTAS"
>
>> making hypercalls (normally RTAS is implemented as guest code) we
>> have nasty hacks to allow that.
>
> Where are such nasty hacks being removed? I just see the cpu argument
> propagated mostly unused throughout code.
[PATCH 08/12] spapr-rtas: use hypercall interface and remove special vty
interfaces
Regards,
Anthony Liguori
>
>>
>> Add a CPU argument to RTAS call handling so we can more easily
>> invoke hypercalls just as guest code would.
>>
>> Signed-off-by: Anthony Liguori <aligu...@us.ibm.com>
>> ---
>> hw/nvram/spapr_nvram.c | 4 ++--
>> hw/ppc/spapr_events.c | 2 +-
>> hw/ppc/spapr_hcall.c | 2 +-
>> hw/ppc/spapr_pci.c | 13 +++++++------
>> hw/ppc/spapr_rtas.c | 21 +++++++++++----------
>> hw/ppc/spapr_vio.c | 6 ++++--
>> hw/ppc/xics.c | 12 ++++++++----
>> include/hw/ppc/spapr.h | 5 +++--
>> 8 files changed, 37 insertions(+), 28 deletions(-)
>
> Otherwise,
>
> Reviewed-by: Andreas Färber <afaer...@suse.de>
>
> Andreas
>
> --
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
