On Tue, Jun 18, 2013 at 09:34:00PM +0400, Michael Tokarev wrote: > The foo.cflags isn't really necessary, but when you specify one > thing one way (target-specific variable), and another thing completely > different way, resulting code does not look nice. In particular, the > two curl definitions in block/Makefile.objs look somewhat funky if > curl.cflags isn't used.
Specifying per-object file or per-module LIBS/CFLAGS is great. I wonder if we can do it like kbuild though: CFLAGS_i915_trace_points.o := -I$(src) It only takes the object file name, not the path. Could be a problem if we have files with the same name in different directories I guess. But I wonder if this approach would let you drop the $(obj)filename.o change. I didn't review closely enough to really understand how that works though :-). Stefan
