Am 30.05.2013 um 14:34 hat Stefan Hajnoczi geschrieben: > The QMP 'transaction' command keeps a list of in-flight transactions. > The transaction state structure is called BlkTransactionStates even > though it only deals with a single transaction. The only plural thing > is the linked list of transaction states. > > I find it confusing to call the single structure "States". This patch > renames it to "State", just like BlockDriverState is singular. > > Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com>
> - /* This removes our old bs from the bdrv_states, and adds the new bs */ > - bdrv_append(states->new_bs, states->old_bs); > + /* This removes our old bs and adds the new bs */ > + bdrv_append(state->new_bs, state->old_bs); Tsk, you said this was only renaming. Don't believe I didn't see it! Reviewed-by: Kevin Wolf <kw...@redhat.com>
