18.06.2013 07:45, liguang wrote: > last parameters of vnc_listen_read,vnc_connect are bool, > so pass 'false/true' instead of '0/1' for them. > > Reviewed-by: Andreas Färber <afaer...@suse.de> > Signed-off-by: liguang <lig.f...@cn.fujitsu.com>
I think I'll apply my version instead, -- which converts remaining arguments of functions your patch touches (so that we don't have this: > - vnc_connect(vs, csock, 0, 0); > + vnc_connect(vs, csock, 0, false); where 3rd argument is also a bool), and which combines your patches 1/5 and 2/5 into one. I'll resend it again in a top-level message. Thanks, /mjt
