在 2013-06-18二的 06:35 +0400，Michael Tokarev写道： > 11.06.2013 15:50, Michael Tokarev wrote: > > 11.06.2013 09:15, liguang wrote: > >> type last parameter of vnc_connect if bool, > >> so pass 'false' instead of '0' for it. > > > > There's another parameter in here, `skipauth', which should be > > bool in vnc_connect(), and should be bool in vnc_display_add_client() > > too. > > > > Also, there's no big point in splitting 1/5 and 2/5 (vnc_listen_read), > > I think. > > > > Does something like the below look ok? (not even compile-tested) > > (and I'd really rename `skipauth' to `doauth' everywhere, to mean > > exactly the opposite so that we don't have double negatives, but > > it is too late already) > > Hello. > > Do you want/plan to respin the series, addressing comments? > Are you okay with my version? >
Yes, I'm little busy now, but I'll re-spin as soon as possible.
