15.06.2013 14:51, Peter Wu wrote: > On Saturday 15 June 2013 14:42:03 Michael Tokarev wrote: > >> Commit 047d4e151dd46 "Unbreak -no-quit for GTK, validate SDL options" broke >> build of qemu without sdl, by referencing `no_frame' variable which is >> defined inside #if SDL block. Fix that by defining that variable >> unconditionally. > > Reviewed-by: Peter Wu <lekenst...@gmail.com>
Thanks! > As for the discussion about legacy options[1], are there plans to remove > `-sdl` (replaced by `-display sdl`) and move the `-*-grab` and `-no-frame` to > `-display sdl` options? If that is the idea, what about printing a message > that the mentioned options are deprecated and removed in a future version? This is already done for sdl, see select_display() function in vl.c -- it handles -display sdl,frame={on|off},... It is unlikely the old options will be removed any time soon, and these will not likely print any warnings either -- this hasn't done for lots of other old options (-stdvga for example). Thanks, /mjt