Re: [Qemu-devel] [PATCH] qdev: Check if unplug handler exists before calling it

[Gerd Hoffmann]

On 11/02/09 07:27, Amit Shah wrote:

A bus may have hotplugging enabled but not have the 'unplug'
callback defined, which would lead to a crash on trying to
unplug a device on the bus.

Which would be a clear bug in the bus implementation.

+    if (!dev->info->unplug) {

assert(dev->info->unplug != NULL) ?

cheers,
  Gerd