On Sun, 06/09 10:39, Wenchao Xia wrote:
> δΊ 2013-6-8 16:21, Fam Zheng ει:
> >On Sat, 06/08 14:58, Wenchao Xia wrote:
> >>Signed-off-by: Wenchao Xia <xiaw...@linux.vnet.ibm.com>
> >>---
> >> hmp-commands.hx | 24 ++++++++++++++++++++++--
> >> hmp.c | 10 ++++++++++
> >> hmp.h | 1 +
> >> 3 files changed, 33 insertions(+), 2 deletions(-)
> >>
> >>diff --git a/hmp-commands.hx b/hmp-commands.hx
> >>index 396691a..65fb94d 100644
> >>--- a/hmp-commands.hx
> >>+++ b/hmp-commands.hx
> >>@@ -1025,8 +1025,7 @@ ETEXI
> >> "of device. If a new image file is specified,
> >> the\n\t\t\t"
> >> "new image file will become the new root
> >> image.\n\t\t\t"
> >> "If format is specified, the snapshot file
> >> will\n\t\t\t"
> >>- "be created in that format. Otherwise the\n\t\t\t"
> >>- "snapshot will be internal! (currently
> >>unsupported).\n\t\t\t"
> >>+ "be created in that format.\n\t\t\t"
> >> "The default format is qcow2. The -n flag requests
> >> QEMU\n\t\t\t"
> >> "to reuse the image found in new-image-file,
> >> instead of\n\t\t\t"
> >> "recreating it from scratch.",
> >>@@ -1040,6 +1039,27 @@ Snapshot device, using snapshot file as target if
> >>provided
> >> ETEXI
> >>
> >> {
> >>+ .name = "snapshot_internal_blkdev",
> >Hmm, Just a boring naming question:
> >
> >snapshot_blkdev reads like a verb-object phrase "snapshot the block
> >device", but snapshot_internal_blkdev is becoming awkward: "snapshot a
> >internal block device"?
> Actually in my draft it is named as snapshot_blkdev_internal, but
> seems not so good also. I am short of English words, how about
> snapshot_internally_blkdev?
>
I prefer snapshot_blkdev_internal, personally.
--
Fam
