Am 05.06.2013 14:36, schrieb Michael S. Tsirkin: >> Anyway, my point was, when moving stuff out of exit, we should also >> change the signature to the new one - DeviceState* and (unused) Error**. >> Then we're getting closer to removing the old exit field, and at that >> point renaming individual hooks - if desired - becomes a trivial patch. > > Why is renaming new hooks related to getting rid of old ones?
* less ambiguity and more names to choose from * introducing new callbacks as done here for instance_finalize requires care for variable names (PCIDevice *dev vs. DeviceState *dev is the classic) whereas renaming a hook once used is a trivial one-line change * renaming hooks now adds to the already existing confusion of a half-done conversion Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
