On 05/30/2013 06:34 AM, Stefan Hajnoczi wrote: > It is not necessary to check that we can find a protocol block driver > since we create or open the image file. This produces the error that we > need anyway. > > Besides, the QERR_INVALID_BLOCK_FORMAT is inappropriate since the > protocol is incorrect rather than the format. > > Also drop an empty line between bdrv_open() and checking its return > value. This may be due to copy-pasting from earlier code that performed > other operations before handling errors. > > Reported-by: Kevin Wolf <kw...@redhat.com> > Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> > --- > blockdev.c | 15 --------------- > 1 file changed, 15 deletions(-)
Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
