On Tue, May 21, 2013 at 9:57 PM, Stefan Hajnoczi <stefa...@redhat.com> wrote: > On Tue, May 07, 2013 at 01:46:55PM +0800, Liu Ping Fan wrote: >> From: Liu Ping Fan <pingf...@linux.vnet.ibm.com> >> >> Hub ports will run on multi-threads, so use lock to protect them. >> >> Signed-off-by: Liu Ping Fan <pingf...@linux.vnet.ibm.com> >> --- >> net/hub.c | 25 ++++++++++++++++++++++++- >> 1 files changed, 24 insertions(+), 1 deletions(-) > > Does this rely on net queue re-entrancy detection? Otherwise we'll > deadlock when slirp re-enters the net layer, for example for ARP > requests. > Yes, you are right.
> I suggest moving this later in the patch series when the net queue is > protected already. > Ok. Thanks Pingfan > Stefan
