On 27 May 2013 12:34, Paolo Bonzini <pbonz...@redhat.com> wrote: > TARGET_ARCH is generally wrong to use, there are better variables > provided in config-target.mak. The right one is usually TARGET_NAME > (previously TARGET_ARCH2), but for bsd-user we can also use TARGET_ABI_DIR > for consistency with linux-user.
Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> > @@ -95,7 +95,7 @@ endif #CONFIG_LINUX_USER > > ifdef CONFIG_BSD_USER > > -QEMU_CFLAGS+=-I$(SRC_PATH)/bsd-user -I$(SRC_PATH)/bsd-user/$(TARGET_ARCH) > +QEMU_CFLAGS+=-I$(SRC_PATH)/bsd-user -I$(SRC_PATH)/bsd-user/$(TARGET_ABI_DIR) > > obj-y += bsd-user/ > obj-y += gdbstub.o user-exec.o This part of this patch gave me pause for a moment since for sparc32plus TARGET_ABI_DIR isn't the same as TARGET_ARCH, but bsd-user is only built for i386/x86_64/sparc/sparc64 so this doesn't actually matter. thanks -- PMM
