On Tue, 05/28 10:10, Paolo Bonzini wrote:
> Il 28/05/2013 08:44, Fam Zheng ha scritto:
> > diff --git a/scripts/create_config b/scripts/create_config
> > index c471e8c..2dfda3e 100755
> > --- a/scripts/create_config
> > +++ b/scripts/create_config
> > @@ -35,11 +35,18 @@ case $line in
> > echo ""
> > ;;
> > CONFIG_BDRV_WHITELIST=*)
> > - echo "#define CONFIG_BDRV_WHITELIST \\"
> > + echo "#define CONFIG_BDRV_WHITELIST_RW \\"
> > for drv in ${line#*=}; do
> > + [[ "${drv}" = ^* ]] && continue;
>
> I didn't know about this feature. Can you point me to the documentation?
Yes, it is bash only, I'd better use a more compatible way.
http://mywiki.wooledge.org/glob
>
> You would need to change the #! header to "#! /bin/bash" if you use it,
> but since you have to respin anyway, I'd ask you to use "case" instead. :)
As Stefan and Kevin pointed out, I'll replace ^ prefix with a separate
configure option, it'll become
CONFIG_BDRV_WHITELIST_RW=*)
...
;;
CONFIG_BDRV_WHITELIST_RO=*)
...
;;
Then I won't need globbing.
--
Fam
