On 05/28/13 02:31, li guang wrote: > 在 2013-05-27一的 11:13 +0200，Gerd Hoffmann写道： >> On 05/24/13 04:47, liguang wrote: >>> when enable DEBUG_DEBUGCON, there are some message >>> printing bugs, so fix them. >> >> I'd suggest to either simply remove the debug printfs or turn them into >> tracepoints. >> > > sorry, why we simply remove debug message printing? > it's un-useful at all?
It's a case-by-case thing. Debug messages logging guest activity like port access tend to be useful for trouble-shooting. They should be turned into tracepoints, so they can be toggled at runtime and integrate nicely with tracing tools. Sometimes debug messages are just leftovers and don't serve a real purpose (any more). Then it is best to simply remove them. In the debugcon case I'd tend to simply remove them given how trivial the device is. But if you prefer making them tracepoints I'm ok with that. cheers, Gerd
