Am 20.05.2013 19:23, schrieb Paolo Bonzini: > We have three variables currently in config-target.h: > > - TARGET_ARCH is used to create a unique per-arch symbol, used in #ifdefs. > It is also used as a string through config-target.h, but this is almost > always wrong. > > - TARGET_ARCH2 is the name of the executable (minus the qemu-/qemu-system- > prefix); it is not available in config-target.h. > > - TARGET_TYPE is an enum but is otherwise the same as TARGET_ARCH2
Add to that - TARGET_BASE_ARCH in Makefile.target is assumed to be the name of the target-* subdirectory, but this will not always be desirable. > This series changes all uses of TARGET_ARCH to refer to TARGET_ARCH2 > instead (which is renamed to TARGET_NAME). The TARGET_ARCH #define > is dropped, only the per-arch symbol remains. TARGET_TYPE is then also > removed since it is serialized to the same string if TARGET_NAME is > used directly. For a long time already I have been carrying the following patch introducing TARGET_ARCH_DIR: https://github.com/afaerber/qemu-rl78/commit/9eddd60dae6603235fddf9070c73e5bf65edf292 Still need to rebase that, but it looks as if there are no conflicts with your series. TARGET_NAME while a bit invasive is certainly nicer than TARGET_ARCH2, and dropping TargetType enum makes rebasing/adding new targets easier. Regards, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
