On 05/08/2013 02:50 AM, qiaonuohan wrote:
>
> Thanks for your suggestion. I will fix it like:
>
> { 'enum': 'DumpCompressionFormat',
> 'data': [ 'zlib', 'lzo', 'snappy' ] }
>
> For zlib is treated as the default compression format, and
> 'uncompressed' won't be an option.No, I was serious that you need to provide 'uncompressed' as an explicit enum value. It is very annoying to toggle between four states (three compression formats and a fourth state of no compression) when the fourth is available only by omitting a parameter. The default MUST be 'uncompressed' for backwards-compatibility, not 'zlib'. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
