On 05/07/13 16:06, Michael S. Tsirkin wrote:
>> +#if 0
> should have a comment explaining why is this
> commented out.
> Or just drop this section.
> 
>> > +        /* event queue (used if ring is full) */
>> > +        VMSTATE_BOOL(er_full,         XHCIInterrupter),
>> > +        VMSTATE_UINT32(ev_buffer_put, XHCIInterrupter),
>> > +        VMSTATE_UINT32(ev_buffer_get, XHCIInterrupter),
>> > +        /* TODO */ XHCIEvent ev_buffer[EV_QUEUE];
>> > +#endif
>> > 

xhci buffers events in case the ring is full.  Doesn't happen under
normal circumstances, thats why I didn't bother finishing it (yet).

Doing that and stress-testing xhci migration are the todo list items
before I'll go merge this series.

cheers,
  Gerd


Reply via email to