Am 06.05.2013 09:55, schrieb Fabien Chouteau: > On 05/05/2013 09:00 PM, Andreas Färber wrote: >> Am 05.05.2013 20:40, schrieb Alexander Graf: >>> >>> >>> Am 05.05.2013 um 19:45 schrieb Andreas Färber <andreas.faer...@web.de>: >>> >>>> This prepares for switching from OpenHack'Ware to OpenBIOS. >>>> >>>> While touching the error handling code, switch from aborting hw_error() >>>> to fprintf()+exit() and suppress failing without -bios for qtest. >>>> >>>> Signed-off-by: Andreas Färber <andreas.faer...@web.de> >>> >>> Acked-by: Alexander Graf <ag...@suse.de> >> >> Thanks, applied to prep-up: >> http://repo.or.cz/w/qemu/afaerber.git/shortlog/refs/heads/prep-up >> >> Sorry, forgot the changelog: >> * error handling was split up as suggested by Alex, >> * missing exit(1) calls were added and > > BTW, why do you use fprintf()+exit() instead of hw_error()?
That error is triggered by the user specifying a wrong -bios argument, so we should fail gracefully (similar discussion about -m a while back) and the CPU states are not so interesting at that point. Andreas
