On Tue, Apr 30, 2013 at 03:55:24PM +0100, Peter Maydell wrote: > On 30 April 2013 15:48, Igor Mammedov <imamm...@redhat.com> wrote: > > Signed-off-by: Igor Mammedov <imamm...@redhat.com> > > --- > > compile tested only ... > > > > --- > > hw/arm/realview.c | 16 ++++------------ > > hw/arm/versatilepb.c | 5 ++--- > > Anything that's only touching these two boards is clearly > not considering the whole situation -- more boards than > just these two have a board specific default CPU.
You're right. In other words: QEMUMachineInitArgs.cpu_model may be an easy-to-find redundant variable that should be eventually replaced by QEMUMachine.cpu_model, but we probably have dozens of local variables used for the same thing in other code. -- Eduardo
