Il 30/04/2013 16:15, KONRAD Frédéric ha scritto: > On 30/04/2013 16:01, Paolo Bonzini wrote: >> Il 30/04/2013 15:06, KONRAD Frédéric ha scritto: >>>> Could this be simply a qdev property? >>> Well, maybe my solution is too extreme. >>> >>> Maybe I can put bus_name in struct VirtIODevice instead to avoid the >>> set_virtio_x_bus_name code duplication? >> No, I think it should be either DeviceState or single devices. >> >> Paolo >> > oops, just sent the fix with bus_name in VirtIODevice.. > > I think it's not necessary to put bus_name in DeviceState as it is only > needed for these two devices. > > But it may be better for it to be in VirtIODevice no?
Yeah, in the end it doesn't look bad... I should let other people who followed the refactoring more closely decide. Paolo
