On 04/25/13 20:47, Anthony Liguori wrote:
> Laszlo Ersek <ler...@redhat.com> writes:
>> +typedef struct acpi_table_std_header {
>> + char sig[4]; /* ACPI signature (4 ASCII characters) */
>> + uint32_t length; /* Length of table, in bytes, including
>> header */
>> + uint8_t revision; /* ACPI Specification minor version # */
>> + uint8_t checksum; /* To make sum of entire table == 0 */
>> + char oem_id[6]; /* OEM identification */
>> + char oem_table_id[8]; /* OEM table identification */
>> + uint32_t oem_revision; /* OEM revision number */
>> + char asl_compiler_id[4]; /* ASL compiler vendor ID */
>> + uint32_t asl_compiler_revision; /* ASL compiler revision number */
>> +} QEMU_PACKED AcpiTableStdHdr;
>
> Since you're giving it a CamelCaseName why don't you do the same for the
> struct. After that:
This was on purpose. The original "struct acpi_table_header" that I was
extracting from had lower_case_underscore_separated name. My impression
was that structure tags were named_like_this, while ordinary identifiers
denoting types were NamedLikeThis. I was trying to follow that.
However I can see now that in general that observation was wrong. I'll
fix it.
Thanks,
Laszlo
