Il 24/04/2013 20:49, Andreas Färber ha scritto: > Am 24.04.2013 13:30, schrieb Paolo Bonzini: >> Il 24/04/2013 12:37, Hu Tao ha scritto: >>> Signed-off-by: Hu Tao <hu...@cn.fujitsu.com> >> >> I had exactly the same patch in my 1.6 queue. :) >> >> Reviewed-by: Paolo Bonzini <pbonz...@redhat.com> > > The commit message fails to explain *why* we can drop updating whatever > RTC memory value there though?
Ultimately the argument was unused (see the ich9_pm_init part of the patch). This is now done with s->suspend_notifier.notify = rtc_notify_suspend; qemu_register_suspend_notifier(&s->suspend_notifier); in hw/timer/mc146818rtc.c. Paolo