Il 26/04/2013 08:02, David Gibson ha scritto:
> vmw_pvscsi.c directly calls pci_dma_sglist_init() instead of using the
> helper for PCI devices, which means it was broken by Paolo Bonzini's
> recent addition of iommu support to the memory API. This fixes it.
>
> Signed-off-by: David Gibson <da...@gibson.dropbear.id.au>
> ---
> hw/scsi/vmw_pvscsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/scsi/vmw_pvscsi.c b/hw/scsi/vmw_pvscsi.c
> index 4b4a58f..68c8d58 100644
> --- a/hw/scsi/vmw_pvscsi.c
> +++ b/hw/scsi/vmw_pvscsi.c
> @@ -617,7 +617,7 @@ pvscsi_build_sglist(PVSCSIState *s, PVSCSIRequest *r)
> {
> PCIDevice *d = PCI_DEVICE(s);
>
> - qemu_sglist_init(&r->sgl, 1, pci_dma_context(d));
> + pci_dma_sglist_init(&r->sgl, d, 1);
> if (r->req.flags & PVSCSI_FLAG_CMD_WITH_SG_LIST) {
> pvscsi_convert_sglist(r);
> } else {
>
Thanks for the heads-up. Though maybe it should just bypass the IOMMU
like virtio, I'll think about it.
Paolo
