On Wed, Apr 24, 2013 at 05:32:00PM +0200, Pavel Hrdina wrote:
> diff --git a/block/sheepdog.c b/block/sheepdog.c
> index 20b5d06..7e0610f 100644
> --- a/block/sheepdog.c
> +++ b/block/sheepdog.c
> @@ -1937,10 +1937,12 @@ out:
> return ret;
> }
>
> -static int sd_snapshot_delete(BlockDriverState *bs, const char *snapshot_id)
> +static void sd_snapshot_delete(BlockDriverState *bs,
> + const char *snapshot_id,
> + Error **errp)
> {
> /* FIXME: Delete specified snapshot id. */
> - return 0;
> + error_setg(errp, "Deleting snapshot is not supported");
> }
Careful, this could break existing tests or applications that expect
snapshot delete to lie. I suggest *not* setting the error for now,
unless Kazutaka agrees it's okay to start erroring now.
